Take into accout a provided remote url when linting all modules #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2243 +/- ##
==========================================
- Coverage 73.12% 73.08% -0.05%
==========================================
Files 77 77
Lines 8342 8344 +2
==========================================
- Hits 6100 6098 -2
- Misses 2242 2246 +4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mashehu
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to tests failing in #2190 I noticed that when linting a module providing a
--git_remoteand linting all modules with--allor indicating so by prompt, all modules are linted independent on the remote they come from.This takes into account the
--git_remoteparam and lints only the modules from that repo.PR checklist
CHANGELOG.mdis updateddocsis updated